Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: spline binning printing and TMatrixD reading #280

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

EdAtkin
Copy link
Contributor

@EdAtkin EdAtkin commented Jan 9, 2025

Pull request description

very tiny fixes to reading in of TMatrixD from root files and also

Changes or fixes

Change to have a static_cast in covarianceBase and change of a single print out for the binning info.

Examples

…om SK det file, so adding in a static cast and removing typed getter
…and also removing a TFile close which wasn't playing nicely with TFile being a unique pointer
@github-actions github-actions bot added the Nu Osc/Xsec Related with neutrino interactions or oscialtions label Jan 9, 2025
Copy link
Contributor

@dbarrow257 dbarrow257 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we could really look at the TMatrixDSym again if we need but I think there always has to be a cast somewhere

@EdAtkin EdAtkin merged commit c5b82b1 into develop Jan 9, 2025
13 of 14 checks passed
@EdAtkin EdAtkin deleted the feature_quick_patches branch January 9, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Nu Osc/Xsec Related with neutrino interactions or oscialtions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants